Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versioned python module name #1143

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

j-rivero
Copy link
Contributor

🦟 Bug fix

Summary

Twin of gazebosim/gz-math#503 to support side-by-side installations.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 15, 2022
@j-rivero j-rivero changed the title Jrivero/versioned python 13 update sdformat Use sdformat13 (versioned) as python module name Sep 15, 2022
@j-rivero j-rivero force-pushed the jrivero/versioned_python_13_update_sdformat branch from 788904f to 09f56ac Compare September 15, 2022 23:51
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1143 (09f56ac) into sdf13 (5cbe319) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            sdf13    #1143   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         125      125           
  Lines       15834    15834           
=======================================
  Hits        13777    13777           
  Misses       2057     2057           
Impacted Files Coverage Δ
python/src/sdf/_gz_sdformat_pybind11.cc 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters changed the title Use sdformat13 (versioned) as python module name Use versioned python module name Sep 16, 2022
@j-rivero j-rivero merged commit 7508a1a into sdf13 Sep 16, 2022
@j-rivero j-rivero deleted the jrivero/versioned_python_13_update_sdformat branch September 16, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants